feat: add share and import features#340
Merged
Merged
Conversation
aldbr
reviewed
May 12, 2025
Contributor
aldbr
left a comment
aldbr
left a comment
There was a problem hiding this comment.
It looks great! Thank you very much 🙂
Could you add some documentation for the developers to explain how to create a state in an "Application" component (e.g. JobMonitor) please?
- As a developer, do we need to implement
exportStateandsetStatein an application? (it will be very similar to every applications, am I wrong? Would it make sense to move these functions elsewhere?) - How am I supposed to save the state of my application? You can explain the session storage and the
<app_id>_State, and how you add/remove details from there (you can use simple examples to highlight the concepts).
Thanks again!
TheauW
force-pushed
the
twartel-share-app-state
branch
from
a504a35 to
cd9ee26
Compare
aldbr
reviewed
May 13, 2025
aldbr
reviewed
May 13, 2025
TheauW
force-pushed
the
twartel-share-app-state
branch
from
cd9ee26 to
502f543
Compare
aldbr
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two new buttons that allows to easily share and import application state. These features enable simple and quick exchange of selected applications between users.